Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform selection prevention in lobby and header #16639

Merged
merged 7 commits into from
Dec 22, 2024

Conversation

johndoknjas
Copy link
Contributor

On a PC, the user isn't allowed to select certain things from the header and areas of the lobby. This PR extends that to include other platforms, like phones. Now something like the following (screenshot from my iphone) won't be possible:

image

@ornicar
Copy link
Collaborator

ornicar commented Dec 21, 2024

Are you sure they're all necessary? According to MDN only safari needs it

@johndoknjas
Copy link
Contributor Author

johndoknjas commented Dec 21, 2024

@ornicar That link only shows an example for Safari, but I'm not sure if they explicitly said that's the only browser that needs it (edit: the table says it is for current versions). It's probably the most important one in any case, though I saw the others mentioned in some SO answers, such as this slightly dated one. They're mainly for supporting older browsers - e.g., -ms-user-select is for IE and non-chromium versions of Edge. Although when highlighting over -ms-user-select in vscode it says it's non-standard and to avoid using it...

@ornicar
Copy link
Collaborator

ornicar commented Dec 21, 2024

You'll find our browser support table here, Edge pre-chromium is not supported.

@ornicar ornicar merged commit 68f0e90 into lichess-org:master Dec 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants