BLADE-742 support quarter release #319
Conversation
| @@ -50,6 +51,8 @@ public class WorkspaceConstants { | |||
|
|
|||
| public static final String DEFAULT_WORKSPACE_PRODUCT_PROPERTY = "liferay.workspace.product"; | |||
|
|
|||
| public static final Pattern dxpQuarterReleaseVersionPattern = Pattern.compile( | |||
There was a problem hiding this comment.
This is just asking to be broken in the future. Can we do without this pattern?
There was a problem hiding this comment.
yes, we could. I will change it.
| public static Map<String, Object> getProductInfos() { | ||
| return getProductInfos(false, null); | ||
| @SuppressWarnings("unchecked") | ||
| public static ProductInfo getProductInfo(String productKey) { |
There was a problem hiding this comment.
ProductInfo should be renamed to ReleaseInfo, since the information is coming from releases.json
| _releaseDate = _safeGet(productMap, "releaseDate", ""); | ||
| _targetPlatformVersion = _safeGet(productMap, "targetPlatformVersion", ""); | ||
| _promoted = Boolean.parseBoolean(_safeGet(productMap, "promoted", "false")); | ||
| public ProductInfo(ProductKeyInfo productKeyInfo, Properties releaseProperties) { |
| @@ -121,6 +122,20 @@ public void testBladeInitEmptyDirectoryHandleTwoDots() throws Exception { | |||
| Assert.assertNotNull(bladeTest.getWorkspaceProvider(emptyDir)); | |||
| } | |||
|
|
|||
| @Ignore | |||
| downloadProductInfo { | ||
| src "https://releases-cdn.liferay.com/tools/workspace/.product_info.json" | ||
| downloadReleasesInfo { | ||
| src "http://localhost:3000/releases.json" |
There was a problem hiding this comment.
The releases.json should be available on a real server somewhere before we merge this. Otherwise the tests won't be valid.
There was a problem hiding this comment.
@gamerson Thanks a lot. This is just a test url before we get the final descision for release info. Because we don't have the completely relases.json, I just put here to let you and drew to do some review. I will do other changes base on your review comments.
|
@simonjhy I spoke further with Zsolt. He will make some adjustments to the format of the |
@drewbrokke 1)About the releases.json. Will we still plan to use two different releases.json files for dxp and portal base on jira ticket description we ? 2) We could sort all product key in our side codes base on the four elements(product, quarterly, liferayProductVersion and release date) now. Sure. We can discuss it on next Tuesday. Thank you. |
No description provided.