feat: Extend GetInfo RPC with LND info. #554
Conversation
rpcserver.go
Outdated
| @@ -286,10 +286,29 @@ func (r *rpcServer) DebugLevel(ctx context.Context, | |||
| func (r *rpcServer) GetInfo(context.Context, | |||
| *taprpc.GetInfoRequest) (*taprpc.GetInfoResponse, error) { | |||
|
|
|||
| // Retrieve the best block hash and height from the chain backend. | |||
| blockHash, blockHeight, err := r.cfg.Lnd.ChainKit.GetBestBlock(context.Background()) | |||
There was a problem hiding this comment.
We should use the inbound context (just need to give it and the *taprpc.GetInfoRequest a parameter name). Here and below.
rpcserver.go
Outdated
| // Retrieve the best block hash and height from the chain backend. | ||
| blockHash, blockHeight, err := r.cfg.Lnd.ChainKit.GetBestBlock(context.Background()) | ||
| if err != nil { | ||
| // Handle error appropriately |
There was a problem hiding this comment.
This comment doesn't give any additional info and should just be removed, here and below.
rpcserver.go
Outdated
| @@ -308,6 +308,7 @@ func (r *rpcServer) GetInfo(context.Context, | |||
| NodeAlias: info.Alias, | |||
| BlockHeight: uint32(blockHeight), | |||
| BlockHash: blockHash.String(), | |||
| SyncStatus: info.SyncedToChain, | |||
There was a problem hiding this comment.
This commit should be squashed with the previous one.
|
could include in a subsequent v0.3 RC if we get the requested changes |
rpcserver.go
Outdated
| NodeAlias: info.Alias, | ||
| BlockHeight: uint32(blockHeight), | ||
| BlockHash: blockHash.String(), | ||
| SyncStatus: info.SyncedToChain, |
There was a problem hiding this comment.
I think it would be better to change SyncStatus to SyncedToChain. As a user, seeing "sync_status": true in the output is pretty vague. It's not clear whether this is related to the chain or graph or something new in tapd regarding universes.
… and block hash Added additional fields to the GetInfo RPC response to provide richer details about the blockchain and the LND node. This includes the LND node's public key (identity), its alias, the current block height, and the latest block's hash.
|
Included a rebased version of the commit in this PR: #589 (keeping author attribution intact). |
Added additional fields to the GetInfo RPC response to provide richer details about the blockchain and the LND node. This includes the LND node's public key (identity), its alias, the current block height, and the latest block's hash.