-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use federation sync config in syncer #564
Conversation
25bdbeb
to
ed3cb1a
Compare
In the fed sync config we differentiate between import and export syncing. This PR doesn't currently handle that nuance. We sync if both import and export is enabled. |
35ebbf9
to
f875fda
Compare
|
f875fda
to
5da8fb8
Compare
34bf7e8
to
ed0ee09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: 7 of 9 files reviewed, 6 unresolved discussions (waiting on @ffranr and @guggero)
rpcserver.go
line 3272 at r3 (raw file):
// TODO(roasbeef): query may return multiple proofs, if allow key to // not be fully specified proof := proofs[0]
if len(proofs) == 0 {
return universe.ErrNoNUniverseProofFound
}]
Code quote:
// TODO(roasbeef): query may return multiple proofs, if allow key to
// not be fully specified
proof := proofs[0]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3.
Reviewable status: 8 of 9 files reviewed, 7 unresolved discussions (waiting on @ffranr and @guggero)
universe/auto_syncer.go
line 490 at r3 (raw file):
// Obtain the general and universe specific federation sync configs. syncConfigs, err := f.QuerySyncConfigs(ctx)
Missing error check.
f1477f8
to
305962c
Compare
Rename reasoning: this method syncs with a server and does not sync with a universe. It will be used to sync multiple universe states with a single server from within the federation.
This change is necessary so that universe federation sync config works by default.
Before this commit, we would insert it all into the same tree. Instead, we'll now properly insert them into distinct trees based on the proof type.
We'll use this in an upcoming test to assert the new sum changes we made earlier in this commit series. Note that we just query the tree directly, as we currently don't have the proper pointers to the leaf and root node.
The top level tree in the issuance multi verse root is just an accumulator value, so we use a value of 1 here.
At times spew can choke on a data structure like our smt tree. Not sure why this didn't really care before, but does now. Either way, allows a test to proceed.
0211bf5
to
d90d30f
Compare
In this PR we modify the simple syncer and the federation envoy such that they use the federation sync configuration.
This change is