-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Release of Money Tally Application #4
Conversation
…nd destroy actions and the specs
Features/first release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lily4178993,
Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Linters passed ✔️
- Beautiful aesthetics ✔️
- Gitflow ✔️
- All test cases passed ✔️
- Well deployed ✔️
Required Changes ♻️
Check the comments under the review.
- You probably forgot to give credit to the designer of the project template you used in your acknowledgement. This is part of the requirement to use the design and even a requirement for this project.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@lily4178993 I think you made changes to your readme and it is now not professional, I picked the link to your live demo and video from your readme and now I cant find it. Kindly add them all as they were and also the acknowledgement. |
There is a problem with Github. The readme exist in the project source but can not be seen. I will try to add it manually |
Oh, that's a glitch from Github then, let me know how it goes though. |
Hi @Olamarx, can you help me? I can't resolve the problem |
Let me take a second look. |
@lily4178993 I will advice you make the submission, I just confirmed that it appears to be a general issue from GitHub because another project has similar issue, the next reviewer should be able to approve it for you. |
@Olamarx, it's solved. I just made the feat branch as default in order to make the readme file appear |
Good job!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lily4178993,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
- Changes fixed ✔️
- Readme file professional ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thank you for the approval! |
Pull Request Overview
I am thrilled to announce the initial release of the "Money Tally" application. This Rails application is designed for straightforward tracking and monitoring of daily expenses.
Introduction to Money Tally
Money Tally is a user-friendly application aimed at simplifying financial management. It allows users to:
Key Features
Purpose and Goals
The primary goal of Money Tally is to offer a simple yet effective tool for managing personal finances. This release is the foundation, providing essential features for efficient expense tracking.
Testing and Quality Assurance
Demo
This release is just the beginning for Money Tally. We eagerly await feedback and contributions from the community to further enhance this personal finance management tool. Thank you for your support!