-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #119, #182, and #185 #199
Fix #119, #182, and #185 #199
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 80.81% 83.45% +2.63%
==========================================
Files 22 26 +4
Lines 1282 1698 +416
==========================================
+ Hits 1036 1417 +381
- Misses 246 281 +35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @christian-oreilly 🚀
Not for this PR - but we might consider Moving these EDF files out of this REPO, and adding a fetch_example_data
function to test them (or something similar).
My concern is that each time we make a change to these files, git
is going to keepi an archive somewhere, which could cause performance issues (for git operations) if our repo size starts to balloon because of multiple archives of these EDF files.
WDYT?
@scott-huberty Totally agree. I'll create an issue on that so that we keep it on the radar. |
Closes #119
Closes #182
Closes #185