Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #119, #182, and #185 #199

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

christian-oreilly
Copy link
Collaborator

@christian-oreilly christian-oreilly commented Dec 10, 2024

Closes #119
Closes #182
Closes #185

@christian-oreilly christian-oreilly added this to the 0.03 milestone Dec 10, 2024
@christian-oreilly christian-oreilly changed the title Adding a test for reproducing #119 Solving the json serialization issue (#119) Dec 12, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (c647153) to head (f47f474).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pylossless/dash/mne_visualizer.py 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   80.81%   83.45%   +2.63%     
==========================================
  Files          22       26       +4     
  Lines        1282     1698     +416     
==========================================
+ Hits         1036     1417     +381     
- Misses        246      281      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-oreilly christian-oreilly changed the title Solving the json serialization issue (#119) Fix #119, #182, and #185 Dec 13, 2024
@christian-oreilly christian-oreilly marked this pull request as ready for review December 13, 2024 05:50
Copy link
Member

@scott-huberty scott-huberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christian-oreilly 🚀

Not for this PR - but we might consider Moving these EDF files out of this REPO, and adding a fetch_example_data function to test them (or something similar).

My concern is that each time we make a change to these files, git is going to keepi an archive somewhere, which could cause performance issues (for git operations) if our repo size starts to balloon because of multiple archives of these EDF files.

WDYT?

@christian-oreilly
Copy link
Collaborator Author

@scott-huberty Totally agree. I'll create an issue on that so that we keep it on the radar.

@christian-oreilly christian-oreilly merged commit 233a536 into main Dec 13, 2024
8 checks passed
@christian-oreilly christian-oreilly deleted the 119-eegannotationlist-not-json-serializable branch December 13, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants