Use As.EXISTING_PROPERTY not to generate JSON with duplicate keys #836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We found
com.linecorp.bot.model.narrowcast.recipient
generated JSON with duplicate keys.For example, audience class is serialized like below.
FasterXML/jackson-databind#528 reported this. The audience class has type filed and generates duplicate
"type": "audience"
if this class doesn't have@JsonTypeInfo(include = JsonTypeInfo.As.EXISTING_PROPERTY)
.Other models don't have type filed, so it's enough to add this config to only this class.
About JSON format, https://www.rfc-editor.org/rfc/rfc7159#section-4 says
So this change follows JSON format the RFC defines.
Thanks!