Skip to content

Commit

Permalink
emacs: fix default values of withFoo flags after overrideAttrs
Browse files Browse the repository at this point in the history
Previously, the normal way to override src and version led to wrong
default values of withFoo flags.

Here is an minimal reproducible example for withXwidgets which should
default to false when version >= 30.

```console
$ nix eval --include nixpkgs=$PWD --impure --expr '
let pkgs = import <nixpkgs> { config = { }; overlays = [ ]; };
in (pkgs.emacs29-pgtk.overrideAttrs { version = "30"; }).withXwidgets
'
true
```

This fix keeps backward compatibility for the .override interface.

Fixes: nix-community/emacs-overlay#455
  • Loading branch information
jian-lin committed Dec 17, 2024
1 parent 145f9be commit 19e5b17
Showing 1 changed file with 169 additions and 116 deletions.
Loading

0 comments on commit 19e5b17

Please sign in to comment.