Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove rdf-js stub #634

Open
wants to merge 3 commits into
base: fix/remove-rdfjs-stub
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"@babel/preset-env": "^7.21.4",
"@babel/preset-typescript": "^7.21.4",
"@babel/register": "^7.21.0",
"@rdfjs/types": "^1.1.0",
"@types/chai": "^4.3.4",
"@types/dirty-chai": "^2.0.2",
"@types/express": "^4.17.17",
Expand All @@ -77,7 +78,6 @@
"nock": "^13.3.0",
"node-fetch": "^3.3.1",
"node-polyfill-webpack-plugin": "^2.0.1",
"rdf-js": "^4.0.2",
"sinon": "^15.0.3",
"sinon-chai": "^3.7.0",
"source-map-loader": "^4.0.1",
Expand Down
2 changes: 1 addition & 1 deletion src/literal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default class Literal extends Node implements TFLiteral {
* Gets whether two literals are the same
* @param other The other statement
*/
equals (other: Term): boolean {
equals (other: Term | null | undefined): boolean {
if (!other) {
return false
}
Expand Down
2 changes: 1 addition & 1 deletion src/node-internal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default abstract class Node {
* Compares whether the two nodes are equal
* @param other The other node
*/
equals (other: Term): boolean {
equals (other: Term | null | undefined): boolean {
if (!other) {
return false
}
Expand Down
2 changes: 1 addition & 1 deletion src/tf-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface Term {
*
* Note that the task force spec only allows comparison with other terms
*/
equals (other: Term): boolean
equals (other: Term | null | undefined): boolean
}

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/types/rdfjs-compatibility.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {
DataFactory,
} from '../../src/index';
import * as RdfJs from 'rdf-js';
import * as RdfJs from '@rdfjs/types';

const factory = DataFactory;

Expand Down
Loading