Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked sub-workflows by a prefix #21

Closed
wants to merge 1 commit into from

Conversation

kuniss
Copy link
Collaborator

@kuniss kuniss commented Sep 14, 2024

to distinguish them from main workflows.
Using local action defintions (as discussed offline) is not possible due to the extensive use of matrix strategies which makes most of the sub-workflow code, logic and reason for existence...

What do you think is better as prefix "subworkflow" or just and one or two underlines "__"?

to distinguish them from main workflows.
Using local action defintions is not possible due to the use of matrix strategies.
@linkrope
Copy link
Owner

linkrope commented Sep 15, 2024

Sorry! I wanted to give this a try:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-an-action-in-the-same-repository-as-the-workflow

I don't like this:

You must check out your repository before using the action.

I didn't change to a branch, however, damaged master, and had to fix it there:
I'm now using the prefix "actions-" to resemble the actions/ directory.

@kuniss
Copy link
Collaborator Author

kuniss commented Sep 25, 2024

No problem.
What do you think? Should we go with your "actions-" prefix or with mine "subworkflow-" prefix?
I guess, in fact it is a sub-workflow, not an action, what we have.
But, I would not insist. Not so important at the end...

@linkrope
Copy link
Owner

What do you think? Should we go with your "actions-" prefix or with mine "subworkflow-" prefix? I guess, in fact it is a sub-workflow, not an action, what we have.

Hm: "subworkflow" is quite long. And even GitHub describes "uses" as:

Selects an action to run as part of a step in your job. An action is a reusable unit of code.

(It's confusing, however, that GitHiub Actions runs workflows.)

@kuniss
Copy link
Collaborator Author

kuniss commented Oct 7, 2024

Let's stay with your "actions-" prefix. It is not that important at the end.
And your changes are already incorporated and working.
So, I'm going to close this PR.

@kuniss kuniss closed this Oct 7, 2024
@kuniss kuniss deleted the distinguish-subworkflows branch October 7, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants