Skip to content

Commit

Permalink
Merge pull request #57 from atticusrussell/ci-table-instructions
Browse files Browse the repository at this point in the history
Add updating CI table to README.md new CI branch instructions.
  • Loading branch information
grassjelly authored Aug 27, 2023
2 parents d598aa0 + 2106e7a commit 2eb75e8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -440,3 +440,5 @@ Once the hardware is done, you can go back to [linorobot2](https://github.com/li
## Developers
#### Adding firmware compilation tests for a new ROS distro
To add a new distro to the CI tests, modify the `rolling` (default) branch. Inside of `.github/workflows`, duplicate an existing distro workflow YAML file. For example, to add ROS2 Iron support, one could copy `humble-firmware-build.yml` to `iron-firmware-build.yml`. Assuming that an `iron` branch exists (if not one could create one using the `humble` branch as a base and modify as necessary), inside of `iron-firmware-build.yml`, rename all instances of the word `humble` with `iron`. It would be as simple as using 'find and replace' in many IDEs. Commit these changes to a feature branch, create a PR to merge into the `rolling` branch, and then backport the PR to other branches. It is only necessary to have `iron-firmware-build.yml` on the `rolling` and `iron` branch, however it may be simpler to keep the branches in sync by having every workflow file on all branches.

Lastly, the new branch must be added to the CI table written in Markdown at the top of README.md that displays the status of each branch using badges. This table is organized with the most current ROS2 branch at the top, which is always `rolling`, and then in descending chronological order. Adding a new distro can be done by copying an existing row of the table, pasting in the appropriate position, and changing the titles and branch names in the relative paths.

0 comments on commit 2eb75e8

Please sign in to comment.