Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci pio (#1) #34

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

atticusrussell
Copy link
Contributor

@atticusrussell atticusrussell commented Jul 2, 2023

A good place to start with CI for PlatformIO builds.
Implements #36

  • build calibration

  • parse firmware/platformio.ini with a python script to get configurations

  • build each firmware configuration in parallel to reduce run time from 40 min to ~7

* parse firmware/platformio.ini with a python script to get configurations

* build each configuration in parallel

* build calibration
@atticusrussell atticusrussell mentioned this pull request Jul 4, 2023
@atticusrussell
Copy link
Contributor Author

@grassjelly what would the procedure be to get this merged?

I would love to continue making more PRs and improvements to this repo, but would want this basic CI system in place to test them.

Some of my ideas for subsequent PRs would be:

  1. Moving the "Galactic" branch to "Rolling" and deprecate branches that don't compile as mentioned in [feature] ROS2 Rolling main, backports #33.
  2. Expand the CI system to test PlatformIO firmware compilation on a matrix of ROS distros.
  3. Devise a system for backporting to older distros from Rolling and troubleshoot issues with each distro from there, such as firmware error #35 that would be relatively simple to solve.
  4. Evaluate existing PRs that aim to add functionality, such as ESP32 port, wifi transport, magnetometer, ultrasonic and battery #31, and thoroughly test them. (in the case of that large PR, maybe proposing that each new feature be in a separate PR that can be carefully evaluated).

@atticusrussell
Copy link
Contributor Author

@grassjelly you mentioned in #37 that you left a comment here and I wanted to let you know that I can't see any comment, but didn't want to leave more unrelated comments in that issue. Not sure what's going wrong.

@grassjelly
Copy link
Member

hey @atticusrussell sorry for the late reply and thanks for the PR. The changes looks good to me, however for the sake of other contributors in the future, could you add comments on the steps. Just briefly add notes and what it does.

@atticusrussell
Copy link
Contributor Author

hey @atticusrussell sorry for the late reply and thanks for the PR. The changes looks good to me, however for the sake of other contributors in the future, could you add comments on the steps. Just briefly add notes and what it does.

@grassjelly Thanks for the feedback. I added comments to the files. Let me know if there's any additional changes you'd like to see.

@grassjelly grassjelly merged commit 272498a into linorobot:galactic Jul 21, 2023
@grassjelly
Copy link
Member

thanks @atticusrussell

@atticusrussell atticusrussell deleted the feature/platformio-ci branch July 21, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants