-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gathercmd test step #115
Conversation
06d59f2
to
f4acb36
Compare
last push changes the event model; instead of emitting the same event on all input targets, just use the first one. This makes it more clear that the setup only ran once, instead of per target. |
todo: add teardown equivalent after #83 is merged. When that happens, anything created by the setup will be uniquely identifier thru output vars and the teardown can act on those artifacts exactly. |
f4acb36
to
cae4e70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would name this something like GatherCmd to make it a bit more clear what it does.
LGTM, the only thing is the obvious RCE, which we already discussed and is the same as with the cmd plugin.
return ts.setParams(params) | ||
} | ||
|
||
// New initializes and returns a new Cmd test step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// New initializes and returns a new Cmd test step. | |
// New initializes and returns a new localsetup test step. |
cae4e70
to
9f44253
Compare
you know.. that's a good point. I was thinking of adding another local_teardown plugin, but it's not different than this one. I should rename to GatherCmd |
- this is a gather type plugin, holds onto all targets and runs the given command once; returns a framework error if the command fails - add to contest generator and server Signed-off-by: mimir-d <[email protected]>
9f44253
to
ad4c3bb
Compare
renamed to GatherCmd test with
|
given command once; returns a framework error if the command fails
testing:
with
Also tested successful setup, failing setup, canceled while running command.