eel-gnome-extensions.c: Support whitespace in execution commands #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwebster
reviewed
Jun 4, 2024
mtwebster
reviewed
Jun 4, 2024
|
I notice we never free @@ -155,4 +155,6 @@ eel_gnome_open_terminal_on_screen (const gchar *command,
g_error_free (error);
}
+
+ g_free (command_line);
} |
A default command line with whitespace will fail to execute, either silently or with a visible error, depending on the trigger. In addition, some actions would default to launching with GNOME Terminal even when another terminal was configured as the default. This adds a default list of terminals, proper switches for execution, and a boolean for whether or not the command line sequence needs to be escaped. Closes linuxmint#2571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A default command line with whitespace will fail to execute, either silently or with a visible error, depending on the trigger. In addition, some actions would default to launching with GNOME Terminal even when another terminal was configured as the default. This adds a default list of terminals, proper switches for execution, and a boolean for whether or not the command line sequence needs to be escaped.
Closes #2571