Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8639] address-search: move components into a4 from mein_berlin PT 1 #1761

Open
wants to merge 1 commit into
base: pv-2025-01-address-search
Choose a base branch
from

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Jan 23, 2025

This is part 1 of 2. Please feel already free to review and merge this. This will be merged into another branch that stems from main and so will part 2. Doing it like this allows me to split this story up for easier review into...

  1. Moving components around (from mb -> a4)
  2. Making further code changes in these components to fulfil the user story.

Once both parts are reviewed & merged into this branch pv-2025-01-address-search I can then merge this into dev (mb)/main (a4)

Describe your changes
Moves components out of mein berlin and into a4, adapts code to be more generic. It moves over:

  1. The useCombobox hook, that is used in a) AutoComplete (AddressSearch) and b) Multi-Select
  2. the useDebounce hook which is used to create debounced callbacks that you can put on e.g. a onChange handler and then it waits x milliseconds before triggering the actual callback and if another change event happens it resets the timer.
  3. The ProjectsMapSearch component (now called AddressSearch) – the main part of this story
  4. The AutoComplete component – which the AddressSearch is built on top of.

meinberlin PR: liqd/a4-meinberlin#5969

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@vellip vellip force-pushed the pv-2025-01-address-search-pt-1 branch from 8168d99 to 97166c7 Compare January 23, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant