-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests/Chaoscenter: Added test cases for Grpc Handler #4189
Conversation
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
Signed-off-by: freedisch <[email protected]>
Signed-off-by: freedisch <[email protected]>
Signed-off-by: freedisch <[email protected]>
https://app.codecov.io/gh/Freedisch/litmus/tree/cov to track the current code cov |
Signed-off-by: freedisch <[email protected]>
Signed-off-by: freedisch <[email protected]>
Signed-off-by: freedisch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀, Can you also add negative cases?
Sure, I'm on it |
Signed-off-by: freedisch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Proposed changes:
This PR add test cases for Chaoscenter authentication handler pkg
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: