Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pytorch 2.2.0, flash attn 2 have been added to pytorch's sdp attn implementation. But it also drop the support of flash attn on Windows platform.
Since this project already require user to install xformers (which have flash attn 2 support on windows by default).
I recommend to use xformers instead of diffusers' default implementation (which use pytorch sdp).
Use xformers also avoid extra transpose operation for q/k/v and attn output.