Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LLVM to 560b72c0408a8f7e4340a1d4197b164a14cd30b0. #8043

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

mikeurbach
Copy link
Contributor

No description provided.

@mikeurbach
Copy link
Contributor Author

We're overdue on an LLVM bump coming off the holidays, so wanted to get the ball rolling.

I'm seeing a few failures, potentially related to the end of the DialectConversion changes (mentioned here):

********************
Failed Tests (3):
  CIRCT :: Conversion/VerifToSMT/verif-to-smt.mlir
  CIRCT :: Dialect/ESI/lowering.mlir
  CIRCT :: Dialect/HW/flatten-io.mlir

cc @mortbopet and @maerhart who helped the last time these tests had issues. I haven't started triaging yet, but will look more closely.

@mortbopet mortbopet requested a review from darthscsi as a code owner January 9, 2025 09:07
@mortbopet
Copy link
Contributor

@mikeurbach ESI and flatten-io tests should now be fixed. It was (again, as in #7976) a case of an existing issue that wasn't actually being checked for. Namely, that exploded hw.structs in a parent hw.module of a hw.instance weren't being re-materialized through hw.struct_create to be fed to an unmodified hw.extern_module.

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikeurbach
Copy link
Contributor Author

Thanks @mortbopet and @maerhart! I will plan to merge at the end of the work day US time.

@mikeurbach mikeurbach merged commit 98ba184 into main Jan 9, 2025
7 of 9 checks passed
@mikeurbach mikeurbach deleted the mikeurbach/bump-llvm branch January 9, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants