Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize value. #122339

Closed
wants to merge 1 commit into from
Closed

Initialize value. #122339

wants to merge 1 commit into from

Conversation

zahiraam
Copy link
Contributor

@zahiraam zahiraam commented Jan 9, 2025 •
edited
Loading

This is an error detected by a static analyzer.

@zahiraam zahiraam requested a review from tahonermann January 9, 2025 19:04
@tahonermann
Copy link
Contributor

The static analysis tool produced a false positive; I see no reason for a change. The static analyzer failed to recognize that APValue::Kind is initialized to None during default construction of the EvalResult variable and that it can't have changed by the time the variable is destructed. The static analyzer falsely determined that DestroyDataAndMakeUninit() could be called from the APValue destructor.

@zahiraam zahiraam closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tahonermann tahonermann Awaiting requested review from tahonermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zahiraam @tahonermann