Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++][NFC] Use uint32_t instead of __uint32_t on Apple #122356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Jan 9, 2025

We had a 15 year old occurence of __uint32_t, likely from a time when uint32_t was not available everywhere.

We had a 15 year old occurence of __uint32_t, likely from a time
when uint32_t was not available everywhere.
@ldionne ldionne requested a review from a team as a code owner January 9, 2025 20:02
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jan 9, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 9, 2025

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

We had a 15 year old occurence of __uint32_t, likely from a time when uint32_t was not available everywhere.


Full diff: https://github.com/llvm/llvm-project/pull/122356.diff

1 Files Affected:

  • (modified) libcxx/include/__locale (+1-1)
diff --git a/libcxx/include/__locale b/libcxx/include/__locale
index 94dc8a08437bfe..8bedd113fb5910 100644
--- a/libcxx/include/__locale
+++ b/libcxx/include/__locale
@@ -348,7 +348,7 @@ public:
 #  define _LIBCPP_CTYPE_MASK_IS_COMPOSITE_ALPHA
 #elif defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__)
 #  ifdef __APPLE__
-  typedef __uint32_t mask;
+  typedef uint32_t mask;
 #  elif defined(__FreeBSD__)
   typedef unsigned long mask;
 #  elif defined(__NetBSD__)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants