Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][AsmPrinter] Pass MJTI by const reference instead of const pointer #122365

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

mingmingl-llvm
Copy link
Contributor

@mingmingl-llvm mingmingl-llvm commented Jan 9, 2025

The caller AsmPrinter::emitJumpTableInfo checks [1] MJTI is not a null pointer before calling emitJumpTableEntry or emitJumpTableSizesSection.

This patch updates callee function's signature to accept const reference, this way it's explicit MJTI won't be nullptr inside the callee.

[1]

@mingmingl-llvm mingmingl-llvm marked this pull request as ready for review January 9, 2025 20:36
Copy link
Contributor

@snehasish snehasish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mingmingl-llvm mingmingl-llvm merged commit a6aa936 into main Jan 9, 2025
9 of 10 checks passed
@mingmingl-llvm mingmingl-llvm deleted the users/mingmingl-llvm/spr/asmprinterrefactor branch January 9, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants