Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump OpenCV to 4.8.1 and include version in the file names #4

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Bump OpenCV to 4.8.1 and include version in the file names #4

merged 1 commit into from
Jan 2, 2024

Conversation

umireon
Copy link
Member

@umireon umireon commented Dec 31, 2023

It would be great if the file name includes its version number

@umireon umireon requested a review from royshil December 31, 2023 10:23
@royshil royshil changed the title Bump OpenCV to 1.1.8 and include version in the file names Bump OpenCV to 4.8.1 and include version in the file names Jan 2, 2024
royshil
royshil approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but why can't i see the version in the filename in the action build artifacts?

@umireon
Copy link
Member Author

umireon commented Jan 2, 2024

This workflow will get the version from the tag but will use the string main as the version when it is executed on PR.

@umireon umireon merged commit d428aad into main Jan 2, 2024
7 checks passed
@umireon umireon deleted the bump-4.8.1 branch January 2, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royshil royshil royshil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umireon @royshil