Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for facet forms #634

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

markconroy
Copy link
Member

Closes #633

What does this change?

Adds CSS so checkbox facets using facets forms look the same as default checkbox facets.

How to test

Follow instructions here to install facets forms.

Images

Screenshot 2024-10-15 at 11 25 54


Thanks to Big Blue Door for sponsoring my time to work on this.

@Adnan-cds
Copy link
Contributor

Hi Mark,
Many thanks for such a quick pull request. It's nearly there. I would request just one improvement: a bit more whitespace between the facets groups. In the following screenshot, a little more space between the "South (1)" facet item and the "Size" facet group label would be great:
image

@markconroy
Copy link
Member Author

@Adnan-cds can you check again?

@Adnan-cds
Copy link
Contributor

Thanks, this will do:
image

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks a lot :)

@finnlewis finnlewis merged commit 0e70057 into 1.x Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front-end styling for the new Directory Facets checkbox template
3 participants