Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored client's symmetric_decrypt_and_verify() #378

Closed

Conversation

BogdanYarotsky
Copy link

Hello, I'm trying to fix the issue that is mentioned in #207 and would like to clean up symmetric_decrypt_and_verify() first.

Here is a list of small changes that I made:

  1. Removed commented out old code
  2. Simplified indexing of slices (using slice directly instead of dst[..], removed "all" variable")
  3. Unified trace message + signature verifying in 2 match arms (Sign, SignAndEncrypt) into a new method

Please let me know if any of the removed code is still needed or I missed something during the refactoring.

Thanks!

@BogdanYarotsky BogdanYarotsky changed the title Symmetric decrypt refs Refactored client's symmetric_decrypt_and_verify() Aug 29, 2024
@BogdanYarotsky BogdanYarotsky deleted the symmetric_decrypt_refs branch September 13, 2024 08:06
@BogdanYarotsky
Copy link
Author

Changes are now split in few PRs for easier review:
#379 #380 #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant