Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only have uid mapping for linux installations #1463

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Only have uid mapping for linux installations #1463

merged 1 commit into from
Dec 9, 2024

Conversation

gjhenrique
Copy link
Contributor

fixes #1462

@gjhenrique gjhenrique changed the title Only touch uid for linux installations Only have uid mapping for linux installations Dec 9, 2024
@gjhenrique gjhenrique mentioned this pull request Dec 9, 2024
Closed
pascalbreuninger
pascalbreuninger approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution 🙌

@pascalbreuninger pascalbreuninger merged commit e60434d into loft-sh:main Dec 9, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalbreuninger pascalbreuninger pascalbreuninger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UID mapping logic breaks devpod on MacOS Docker Desktop
2 participants
@gjhenrique @pascalbreuninger