Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of single quotes when setting git username or email #1482

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix use of single quotes when setting git username or email #1482

merged 1 commit into from
Dec 17, 2024

Conversation

bkneis
Copy link
Contributor

@bkneis bkneis commented Dec 17, 2024

Fixes #1479

@bkneis bkneis requested review from pascalbreuninger and a team December 17, 2024 07:21
pascalbreuninger
pascalbreuninger approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 3151b8d into loft-sh:main Dec 17, 2024
17 of 23 checks passed
@bkneis bkneis deleted the feature/fix-git-username branch December 17, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalbreuninger pascalbreuninger pascalbreuninger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appostrophes in git user name crash the SSH provider
2 participants
@bkneis @pascalbreuninger