Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(desktop): do not block specifying options if command is used from desktop. The options will be filled in later #1522

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(desktop): do not block specifying options if command is used from desktop. The options will be filled in later #1522

merged 1 commit into from
Jan 7, 2025

Conversation

pascalbreuninger
Copy link
Member

@pascalbreuninger pascalbreuninger commented Jan 7, 2025 •
edited
Loading

fixes #1507

@pascalbreuninger
fix(desktop): do not block specifying options if command is used from…
c729eb8 
… desktop. The options will be filled in later
@pascalbreuninger pascalbreuninger requested a review from a team January 7, 2025 07:34
bkneis
bkneis approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 450a83a into loft-sh:main Jan 7, 2025
17 of 24 checks passed
@pascalbreuninger pascalbreuninger mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkneis bkneis bkneis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes Provider Issue w/Latest Update (v0.6.6)
2 participants
@pascalbreuninger @bkneis