Support COMPOSE_PROJECT_NAME #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1513
Currently we always set the docker compose project name, using the
--project-name (-p)flag inpkg/devcontainer/compose.go, with an auto generated name. This is the highest priority way of setting the project name according to the docs and therefore can never to overridden.This PR introduces the ability for a user to set the project name via an env var so that the project name be known in advance. Since this is supported by docker-compose I thought we should support as well. See the issue for an example of not knowing the project name.
To test this PR set the env var
COMPOSE_PROJECT_NAME=testand run devpod up using a docker compose example to see the naming taking effect.