New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/open vscode logs #1535

Merged

pascalbreuninger merged 2 commits into loft-sh:main from pascalbreuninger:chore/open-vscode-logs

Jan 10, 2025

Member

pascalbreuninger commented Jan 10, 2025

chore(cli): only report errors when opening VSCode if at least one method from CLI and custom scheme actually fails
chore(cli): add displayName to VSCode flavor for clearer log output


          chore(cli): only report errors when opening VSCode if at least one me…

0f6bba4

…thod from CLI and custom scheme actually fails

pascalbreuninger requested a review from a team

January 10, 2025 13:04


          chore(cli): add displayName to VSCode flavor for clearer log output

46e73c4

pascalbreuninger force-pushed the chore/open-vscode-logs branch from 2f42a65 to 46e73c4 Compare

January 10, 2025 13:07

bkneis approved these changes

View reviewed changes

Contributor

bkneis left a comment

LGTM

pascalbreuninger merged commit 8e5ace8 into loft-sh:main

17 of 23 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet