Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DevPod up command to allow SSH agent forwarding #734

Merged

Conversation

neogopher
Copy link
Collaborator

@neogopher neogopher commented Oct 11, 2023

Closes ENG-2020
Closes ENG-2006
Closes #673

@neogopher neogopher force-pushed the refactor-allow-ssh-agent-forwarding branch from 3392abf to e3c1036 Compare October 11, 2023 10:31
@neogopher neogopher force-pushed the refactor-allow-ssh-agent-forwarding branch from 06ba959 to 9ed2cd8 Compare October 12, 2023 12:19
Copy link
Contributor

@89luca89 89luca89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe we can find a way to e2e test this?

pkg/devcontainer/setup/setup.go Show resolved Hide resolved
pkg/devcontainer/setup/setup.go Show resolved Hide resolved
cmd/up.go Outdated Show resolved Hide resolved
cmd/up.go Show resolved Hide resolved
cmd/up.go Outdated Show resolved Hide resolved
pkg/devcontainer/setup.go Outdated Show resolved Hide resolved
cmd/up.go Outdated Show resolved Hide resolved
@neogopher neogopher force-pushed the refactor-allow-ssh-agent-forwarding branch from 9ed2cd8 to 72b8394 Compare October 26, 2023 07:25
Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 4c61f0c into loft-sh:main Oct 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH agent not being forwarded during postCreateCommand
4 participants