Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: parallelize tests using labels and matrix #799

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

89luca89
Copy link
Contributor

@89luca89 89luca89 commented Nov 7, 2023

Improve e2e tests by running them in separate jobs, so that they can fail earlier and run in parallel

Resolves ENG-2326

@FabianKramm
Copy link
Member

@89luca89 the problem I see here is that a couple of tests are super fast, but up takes 18m alone, can we split up the up test and merge a couple of fast ones together?

@89luca89
Copy link
Contributor Author

@89luca89 the problem I see here is that a couple of tests are super fast, but up takes 18m alone, can we split up the up test and merge a couple of fast ones together?

Sure, I'll check a logic to split them, so we also have some granularity with job retrying

@89luca89 89luca89 force-pushed the tests/parallelize_tests branch from 2ed68f7 to 7a3a5f8 Compare November 17, 2023 15:38
Signed-off-by: Luca Di Maio <[email protected]>
@89luca89 89luca89 force-pushed the tests/parallelize_tests branch from 7a3a5f8 to d3ebf20 Compare November 17, 2023 15:50
@89luca89
Copy link
Contributor Author

@89luca89 the problem I see here is that a couple of tests are super fast, but up takes 18m alone, can we split up the up test and merge a couple of fast ones together?

Done

Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit b748265 into loft-sh:main Nov 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants