-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setting up existing container as devcontainer #839
feat: support setting up existing container as devcontainer #839
Conversation
b5e98cc
to
5e67472
Compare
5e67472
to
568bb15
Compare
Let me know if I should add/update any existing tests (suites). To run
|
499813a
to
3d0e161
Compare
@amitds1997 we have a failing test, could you have a look at that please? |
Seems like an issue with pulling docker image (log link). Might this be an intermittent thing? The workflows on the previous commit all passed (including the failing one). Since then, I have only added a comment. So, nothing should break. Nonetheless, I am trying to reproduce this locally, in case something is amiss. I would go ahead and add an e2e test for launching devpod with a running container. |
yeah I thought the same earlier, that's why I re-ran the tests. Let's try again tomorrow, maybe it'll sort itself out 🤷♂️
that'd be great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged, thanks a lot @amitds1997!
Hey @pascalbreuninger, when are we planning to send out a release with these changes? Are there going to be more alpha releases? Thanks! |
we can cut an alpha now, was planning to do a stable one towards the end of the month edit: pipelines are running @amitds1997 https://github.com/loft-sh/devpod/releases/tag/v0.5.0-alpha.2 |
BTW Pascal, do we have any documentation for this feature? |
@hrittikhere since today we do, yep :D docs |
Closes #782.