-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: start workspace in a subpath #898
Conversation
Signed-off-by: Luca Di Maio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
This looks good if we want to fork the entire repo. For larger monorepos we might be interested in implementing sparse checkouts. |
Signed-off-by: Luca Di Maio <[email protected]>
Yea was thinking about this but maybe as a separate option? Like This way it could be useful to have a full-checkout+subdir (maybe to access the rest of the project?), or a sparsecheckout that will automatically do also the subdir |
Signed-off-by: Luca Di Maio <[email protected]>
Yeah, adding sparse checkout later makes more sense. You're right.
I probably wouldn't do that. Assuming one might want to check out multiple folders, args should accept a comma-delimited list or paths to checkout, and then one can use the flag from this PR to change the working directory. |
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
Signed-off-by: Luca Di Maio <[email protected]>
388e962
to
2cb2ce4
Compare
Signed-off-by: Luca Di Maio <[email protected]>
2cb2ce4
to
37fc6f7
Compare
feat: start workspace in a subpath
Initial draft to support specifying a subpath where to start a workspace
When specified the subpath will be used as:
Full project will anyway be cloned and mounted into the container
Useful for monorepos
Resolves ENG-1976
I'm still not sure if this is the best way to do it, but it works for now, want to discuss here the implementation in the GUI, and if there are missing pieces
EDIT: to change subfolder, you use
--recreate
also, so it can switch also container