Merge pull request #2255 from cbron/eng-5011-backport

[0.20] fix(helm): Do not download helm if not needed
loft-sh · Oct 31, 2024 · 7808698 · 7808698
2 parents b375fe1 + 4c19189
commit 7808698
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/controllers/deploy/start.go b/pkg/controllers/deploy/start.go
@@ -23,9 +23,12 @@ func RegisterInitManifestsController(controllerCtx *config.ControllerContext) er
 		return err
 	}
 
-	helmBinaryPath, err := helmdownloader.GetHelmBinaryPath(controllerCtx.Context, log.GetInstance())
-	if err != nil {
-		return err
+	var helmBinaryPath string
+	if controllerCtx != nil && controllerCtx.Config != nil && len(controllerCtx.Config.Experimental.Deploy.VCluster.Helm) > 0 {
+		helmBinaryPath, err = helmdownloader.GetHelmBinaryPath(controllerCtx.Context, log.GetInstance())
+		if err != nil {
+			return err
+		}
 	}
 
 	controller := &Deployer{