Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login prompt wrapper and DeGiro constructor function #28

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

konpsar
Copy link

@konpsar konpsar commented Dec 9, 2020

I had an idea to create a function that prompts for password (hiding it while typing), because I didn't like the idea to include my passwords in all .py scripts I used.

Added functions to init.py

  • login_prompt(...)
  • Constructor using login_prompt()

Notes

  • login_prompt is a wrapper function of existing login() function
  • Constructor was carefully created, in order not to brake older use cases.
    Some use cases examples can be seen in examples.py which I've also updated.

Your feedback will be appreciated!

Pablo and others added 10 commits July 31, 2020 17:20
allow log in with 2fa
Added to extend login function to dynamically ask password/totp from user, hiding password while typing.
In this way, password doesn't have to be included in .py scripts.
Constructor enbales an option to automatically login when creating DeGiro instance. (using  login_prompt)
Updated examples to include some use cases of constructor and login_prompt.
Co-authored-by: Jakub Loucký <[email protected]>
Co-authored-by: Jakub Loucký <[email protected]>
Co-authored-by: Jakub Loucký <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants