-
-
Notifications
You must be signed in to change notification settings - Fork 170
Added og: image, og:url and robots meta tags to help SEO #193
Conversation
Deploy preview for upbeat-albattani-cbe0ee ready! Built with commit 14de25b https://deploy-preview-193--upbeat-albattani-cbe0ee.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opengraph preview doesnt show much as of now, unless the title and the icon. Maybe i should have been more precise with the end result. E.g. If you share the github repo of this, you will see the official image. At least this image should be shown and a short description.
resources/icons.json
Outdated
"title": "Fontello", | ||
"desc": "Fontello has a collection of icons from various font and icon toolkits and the icons can be individually selected and downloaded. This greatly improves the website performance owing the reduced css to download.", | ||
"url": "http://fontello.com/", | ||
"tags": ["tag"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either provide no tag at all or at least three tags that describe the resource.
resources/php.json
Outdated
@@ -67,6 +67,12 @@ | |||
"desc": "134 Slides to help fix your code. Performance and testing are just one aspect of code, to really be successful your code needs to be readable, maintainable and generally easier to comprehend and work with.", | |||
"url": "https://www.slideshare.net/rdohms/your-code-sucks-lets-fix-it-15471808", | |||
"tags": [] | |||
}, | |||
{ | |||
"title": "Stuck at a code? Let's find the problem", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This resource does not add much value to be honest. Linting should be done in the IDE and not by pasting it on some website. Can you please remove this?
Summary of the commit:
|
Fix for https://github.com/webgems/webgems/issues/151 opengraph tags are added. Also added a point in PHP and icons