Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix dependabot config and expand to Cargo and GitHub Actions #25791

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Jan 7, 2025

The additional reviewers field is preventing dependabot from running. Fix it, and also expand the scanned dependencies to Rust crates and GitHub Actions.

The additional `reviewers` field is preventing dependabot from running.

Signed-off-by: Gary Guo <[email protected]>
@nbdd0121 nbdd0121 requested a review from jwnrt January 7, 2025 14:03
@nbdd0121 nbdd0121 requested a review from rswarbrick as a code owner January 7, 2025 14:03
Copy link
Contributor

@jwnrt jwnrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Is there a way to do a test run?

Also, I double checked and dependabot doesn't support Bazel yet (though renovate does).

@nbdd0121
Copy link
Contributor Author

nbdd0121 commented Jan 7, 2025

I'm not aware of a way to trigger a manual run

@nbdd0121
Copy link
Contributor Author

nbdd0121 commented Jan 7, 2025

I enabled dependabot updates on my fork and it starts creating PRs: https://github.com/nbdd0121/opentitan/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen

@nbdd0121
Copy link
Contributor Author

nbdd0121 commented Jan 7, 2025

In https://github.com/nbdd0121/opentitan/network/updates/944443966, somehow it's trying to evaluate yum-requirements.txt as Python requirements file?

Also, we probably want to ensure Cargo dependencies are up-to-date before merging this PR to avoid a lot of dependabot PRs.

@jwnrt
Copy link
Contributor

jwnrt commented Jan 7, 2025

Do we want it to be creating PRs? I think the security advisories tab would be good enough

@nbdd0121
Copy link
Contributor Author

nbdd0121 commented Jan 7, 2025

My fork's security advisory page doesn't include third_party/rust/Cargo.toml as a source. Maybe I'll need to wait a bit for GitHub to rescan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants