[dd, prim] Simplyfing condition to ease coverage closure #25814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The acknoledgement can't be set unless the request is set. The condition has been simplified to only check for the acknoledgment. In addition, the new assertion checks if the ack is set, the request must be set Signed-off-by: Antonio Martinez Zambrana <[email protected]>
rswarbrick
reviewed
Jan 8, 2025
Comment on lines
+158
to
+161
| // The condition above was originally `dst_update_req && dst_update_ack`. | ||
| // However, since there can't be an ACK without a REQ that means the condition | ||
| // can be simplified to `dst_update_ack` only. | ||
| // Assertion `DstAckReqChk_A` checks the above always happens |
There was a problem hiding this comment.
I don't think we need this comment in the code?
Comment on lines
+172
to
+173
| // dst_update_ack should only be sent if there was a dst_update_req. | ||
| // By association, whenever src_ack is seen, then src_busy must be high. |
There was a problem hiding this comment.
I don't think you wanted to copy this comment as well :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acknoledgement can't be set unless the request is set. The condition has been simplified to only check for the acknoledgment.
In addition, the new assertion checks if the ack is set, the request must be set