Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sim_sram] Fix connections to TLUL adapter and SRAM #25836

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Jan 9, 2025

Both modules have missing unused connections, add them

@Razer6 Razer6 requested a review from a team as a code owner January 9, 2025 16:00
@Razer6 Razer6 requested review from marnovandermaas, rswarbrick, nasahlpa, vogelpi and a team and removed request for a team January 9, 2025 16:00
Both modules have missing unused connections, add them

Signed-off-by: Robert Schilling <[email protected]>
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we haven't used this module very carefully recently! :-)

Looks sensible to me, thanks.

@rswarbrick rswarbrick merged commit 8be56e7 into lowRISC:master Jan 10, 2025
38 checks passed
@Razer6 Razer6 deleted the fix-sim-sram branch January 10, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants