[rom] fix bug in ROM that computes OTP measurements #25975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfrantz
approved these changes
Jan 22, 2025
sw/device/silicon_creator/rom/e2e/keymgr/rom_e2e_keymgr_init_test.c
Outdated
Show resolved
Hide resolved
timothytrippel
force-pushed
the
fix-otp-hash-bug
branch
from
5b07e35 to
cb0e5ad
Compare
This fixes a bug in the ROM that computes OTP measurements to populate the keymgr attestation binding CSRs, if the OTP fuse (`OWNER_SW_CFG_ROM_KEYMGR_OTP_MEAS_EN`) to request this is set. Additionally, this fixes the corresponding ROM E2E test as well, and enhances its robustness. Signed-off-by: Tim Trippel <[email protected]>
timothytrippel
force-pushed
the
fix-otp-hash-bug
branch
from
cb0e5ad to
27a35e9
Compare
moidx
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the ROM that computes OTP measurements to populate the keymgr attestation binding CSRs, if the OTP fuse (
OWNER_SW_CFG_ROM_KEYMGR_OTP_MEAS_EN) to request this is set. Additionally, this fixes the corresponding ROM E2E test as well, and enhances its robustness.