-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[assert] Add ASSERT_KNOWN asserts to multiple new outputs #25999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Razer6 this looks good to me!
Nits:
- Some comments mention that the outputs need to be known after reset. But AFAIK the SVA actually checks they're known all the time.
- One commit message has nbx in the title, I think it should be mbx.
CHANGE AUTHORIZED: hw/ip/i2c/rtl/i2c.sv This PR only adds missing ASSERT_KNOWN assertions. This doesn't have functional impact. |
I changed the |
The address can have 'x and this would be progated to the RACL error. Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
CHANGE AUTHORIZED: hw/ip/i2c/rtl/i2c.sv This PR is just adding some extra assertions (that we originally missed). No change in functional behaviour. |
This adds ASSERT_KNOWN assertions to many outputs of the newly introduced signals.
It also uncovered a bug. The RACL error may be
'x
because the internal address hit depends on the incoming TLUL address, which might be'x
at some cases. To fix this, thea_valid
signal is factored in to the RACL error computation.