-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/sitcom 1450 #7
Conversation
- Update the link of SITCOM-079 with the last version - Remove text about lastest version of technote and old format because is done.
- Add information about the not change of format despite a specific finalized ticket for this task.
- Update the link with the last technote version. - Update the results of the analysis. - Update the pending tasks
- Technote in new format - New commets add in the last version - Pending task: update the current version for the last one and perform the tasks indicated in requirements in verification.
Include in the pending update the format of the technote.
Pending task: Update the version of the technote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments to request further information in a few items. Left open to merge .
index.rst
Outdated
@@ -105,7 +105,7 @@ Force balance tests | |||
|
|||
*Results*: After applying different forces at 10% to 100% performance, maximum are occasionally seen at above 1000N, whereas the limit currently stands at 900 N. | |||
|
|||
*Pending tasks*: Update technote to reflect most recent results (shown at the Glass Safety review) and merge into main. Define next steps, and possible risk minimization. Technote format is old. | |||
*Pending tasks*: Update technote to reflect most recent results (shown at the Glass Safety review) and merge into main. Define next steps, and possible risk minimization. Technote format is old. There is a ticket (`SITCOM-1463 <https://sitcomtn-092.lsst.io/v/SITCOM-1463/index.html>`) to change the format but although it shows as done, the ticket information does not appear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check with the authors why is this the case? (why technote 92 does not appear updated to the new format?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marina Pavlovic on ticket SITCOM-1463 migrated the tecnote to the new format but she did not copy the information. The current version shown still has the old format but I don't know why.
|
||
*Results*: After the improvements made in July 2023 to the Look-Up Table (LUT), the hardpoint measured forces have been minimized. The “rule of thumb” for the LUT is that we should expect about 1/1000 correction. Our mirror weighs 170,000 N. We should expect to get within 170N. It looks like we are within this range. | ||
|
||
*Pending tasks*: To further improve the LUT, tests could be performed to validate that we have reached convergence and the LUT includes all the gravitational loads dependency. Merge latest version of technote into main, technote format is old. | ||
*Pending tasks*: To further improve the LUT, tests could be performed to validate that we have reached convergence and the LUT includes all the gravitational loads dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked with Guillem about the status of technote 79 and results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just saw that there was a new version in technote, with the new format and all the information copied.
index.rst
Outdated
@@ -138,9 +138,10 @@ Hardpoint tests | |||
|
|||
* `SITCOMTN-082 <https://sitcomtn-082.lsst.io/>`_ **M1M3 Hardpoint Breakaway** | |||
|
|||
*Results*: Breakaway system works in general. Some notable exceptions (HP2, HP5 breakaway system faults at low (<30 deg) elevations, response shape also different) seem to be have an explanation according to Yijung and Petr. | |||
*Results*: Breakaway system works in general. Some notable exceptions (HP2, HP5 breakaway system faults at low (<30 deg) elevations, response shape also different) seem to be have an explanation according to Yijung and Petr. The format of the technical notes is in the new format (SITCOM-1111-2 dated 2024-01-23). However, these updates are not shown in the “Current” version which is in the old format. The technical note SITCOM-111-2 contains more explanations and conclusions than the current one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check with the authors why is this the case? (why technote 82 does not appear updated to the new format?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yijung kang is the author who appears in the tecnhote with the new format ( https://sitcomtn-082.lsst.io/v/SITCOM-1111-2/index.html). However, I am not sure if this author is the one who changed the technote format. I can't see who is the author that migrated the tecnote from the old format to then new one because there is no associated ticket
No description provided.