Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/DM-47420: WET-007 using comCam WET-001 simulation #1

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

suberlak
Copy link
Contributor

@suberlak suberlak commented Nov 6, 2024

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Nov 9, 2024

View / edit / reply to this conversation on ReviewNB

jbkalmbach commented on 2024-11-09T07:26:58Z
----------------------------------------------------------------

Is the disagreement in the astigmatism common across many states? Could be interesting to look at the difference in each individual Zernike (or at least the first few) to see if there are any trends there.


suberlak commented on 2024-11-27T00:54:15Z
----------------------------------------------------------------

Added differences in astigmatism across states

Copy link

review-notebook-app bot commented Nov 9, 2024

View / edit / reply to this conversation on ReviewNB

jbkalmbach commented on 2024-11-09T07:26:59Z
----------------------------------------------------------------

Could you add some timing information comparing the Danish to TIE at our current state of development? Or do we have that in another notebook already somewhere?


suberlak commented on 2024-11-27T00:53:18Z
----------------------------------------------------------------

Added timing comparison

@jbkalmbach jbkalmbach self-requested a review November 9, 2024 07:27
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple comments.

Copy link
Contributor Author

Added timing comparison


View entire conversation on ReviewNB

Copy link
Contributor Author

Added differences in astigmatism across states


View entire conversation on ReviewNB

@suberlak suberlak merged commit b0b2662 into main Nov 27, 2024
2 checks passed
@suberlak suberlak deleted the tickets/DM-47420 branch November 27, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants