Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U/jbkalmbach/fix nbstripout #16

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

U/jbkalmbach/fix nbstripout #16

wants to merge 2 commits into from

Conversation

jbkalmbach
Copy link
Member

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jbkalmbach jbkalmbach requested a review from suberlak January 16, 2025 22:20
suberlak
suberlak approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@suberlak suberlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the update! Does this mean that nbstripout will be run as part of github actions? Would the error that "notebook cell outputs were found" be only triggered in case that the nbstripout failed to run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suberlak suberlak suberlak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbkalmbach @suberlak