DM-48552: Remove requestPath from job Filtering - Allows synchronous queries to show up under uws job list #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want both sync and async queries to appear in the UWS async job list. Our interpretation of the IVOA spec seems to allow this if in the back end we are running synchronous queries as jobs as well. In some ways we are so I think we are ok to do this. More importantly this aligns with the functionality we want for query history, where Firefly and other clients will be able to get a user's query history from the UWS job list, regardless of if the job was run sync or async.
Fix
The fix implemented here was to remove the requestPath that normally get's used by the TAP service to filter out jobs. So until now, the jobs are filtered with something like requestPath="tap/async" so we just set this to null to remove this filter all together.
How was this tested?
Tests were done manually. I created a sync job, and then checked the job lists (using LAST=1) and made sure the last job that appears was infact the sync job I just ran