DM-46898: Reconfigure RA for ComCam on sky #4071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-46898
branch
from
f64448f to
052d97d
Compare
ctslater
approved these changes
Jan 14, 2025
| - name: {{ $.Release.Name }}-butler-secret | ||
| mountPath: {{ $.Values.butlerSecret.containerPath }} | ||
| {{- end }} | ||
| {{- if or $.Values.resources $script.resources }} |
There was a problem hiding this comment.
There are a bunch of these ".values or script" blocks (nodeSelector, affinity, tolerations, etc), which I think can each be replaced by something like:
{{- if or $.Values.resources $script.resources }}
{{- $resources := $script.resources | default $.Values.resources }}
resources:
{{- toYaml $resources | nindent 12 }}
{{- end }}
I've tried this out and it seems to behave correctly for all the combinations I could come up with. Or you could even inline it as {{- $script.resources | default $.Values.resources | toYaml | nindent 12}}, but I haven't tested that one. Still requires the if statement as a guard around the resources block.
| chown 73006:73006 /secrets/* | ||
| chmod 0600 /secrets/* | ||
| volumeMounts: | ||
| - name: {{ $.Release.Name }}-raw-butler-secret |
There was a problem hiding this comment.
Why does this include $.Release.Name?
…without location prefix
sebastian-aranda
force-pushed
the
tickets/DM-46898
branch
from
18fdfbd to
37630a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.