Organized util functions in utils directory. #204
Merged
+1,381
−1,184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfcrenshaw
force-pushed
the
tickets/DM-41092
branch
from
c5ac4f0 to
f6c109d
Compare
jbkalmbach
approved these changes
Oct 9, 2023
doc/versionHistory.rst
Outdated
| .. _lsst.ts.wep-6.4.13: | ||
|
|
||
| ------------- | ||
| 6.4.13 |
There was a problem hiding this comment.
This should probably be a major version update since it will break backwards compatibility. A little annoying but I think each of your updates may have to increment the major version number for the same reason. It would be better if we had structure to put everything on a release branch but let's not worry about that now.
There was a problem hiding this comment.
Ah yeah, good point. I changed the version to 7.0.0
jfcrenshaw
force-pushed
the
tickets/DM-41092
branch
from
f6c109d to
7ed5b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR towards merging the new implementation of the TIE into ts_wep. This PR just centralizes all of the utility functions into a utils module.
The PR touches a lot of files, because it
(1) moves and organizes the util functions in the utils module
(2) changes lots of imports in ts_wep to
from lsst.ts.wep.utils import ...(3) moves the corresponding unit tests around to reflect the restructuring
However, this PR makes no real changes to any code or tests. It merely moves things around for better organization, so that the changes made by the big TIE refactor will touch the fewest number of files possible.