-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Minetest Game screenshot in /media/gallery, issue #265 #302
Conversation
The official repository for minetest.github.io fails the same checks. I don't understand why though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, friendlier scenery, showcases rendering a bit better. Have you tried optimizing file size? (Sizes are still acceptably small, but there is a notable increase).
What may be debatable is that the new screenshot doesn't show HUD, but I think it's better (less cluttered) this way.
There is a "downgrade", though: The new screenshot is relatively low res (old one is 1920 x 1080, new one is 1280 x 678).
I do have the same screenshot with the HUD and a higher resolution (1920 x 1011) if that is preferable. |
Yes, that would be preferable. Why such an odd resolution though? I would expect 1920 x 1024. |
You should full screen Minetest so it takes a complete 1920x1080 screenshot. |
The screenshot needs some antialiasing :) |
I like it. Can I use it for my pull request? |
Sure. |
…rg#265. Image provided by sfan5.
Alt text in |
Why does it need updating? |
Nevermind, I accidentally looked at an old revision where it still said "An underwater jungle in Minetest Game". |
Updated the Minetest Game screenshot in /media/gallery to show dynamic shadows and bloom, as wanted in issue #265. Screenshot was taken in Minetest version 5.9.0-dev.