Replace xz2 with liblzma #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 81.08% 81.57% +0.49%
==========================================
Files 12 12
Lines 259 266 +7
==========================================
+ Hits 210 217 +7
Misses 49 49 ☔ View full report in Codecov by Sentry. |
|
Nice I fix trouble with xz, lzma features. |
|
I would wait finish test before merge. Maybe after, this merge we could perform a dependency update before a new minor release ? |
natir
approved these changes
Jun 8, 2024
yup! Thanks for the quick review =] |
treat 'xz' as an alias to 'lzma', and only check for 'lzma' in code This reverts commit 66e482e.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xz2 is outdated 1, liblzma is an updated fork.
Footnotes
that might not be bad, since being outdated meant the updated to the hacked version was never done 😅 https://github.com/alexcrichton/xz2-rs/issues/124#issuecomment-2027962381 ↩