Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should implement dictionaries feature. #169

Open
hwanseung opened this issue Nov 9, 2017 · 0 comments
Open

Should implement dictionaries feature. #169

hwanseung opened this issue Nov 9, 2017 · 0 comments
Assignees
@hwanseung

Comments

@hwanseung
Copy link
Contributor

Should implement dictionaries feature.
@hwanseung hwanseung self-assigned this Nov 9, 2017
@hwanseung hwanseung mentioned this issue Nov 12, 2017
Merged
romandev pushed a commit that referenced this issue Nov 29, 2017
@hwanseung @romandev
Implement to call function which take dictionaries type as parameter (#…
578ba56 
…185)

This patch is first step to implement dictionaries feature.
it is possible only to call function which take dictionaries type 
as parameter in this patch. so we should implement below things
to enhance dictionaries feature.
 - convert native object from javascript type and pass as parameter
 - should implement function which return dictionaries type

ISSUE=#169
hwanseung added a commit to hwanseung/bacardi that referenced this issue Dec 10, 2017
@hwanseung
Remove unused file.
3bfea30 
it was unused file.
but it was included when dictionary feature work.

ISSUE=lunchclass#169
@hwanseung hwanseung mentioned this issue Dec 10, 2017
Merged
hwanseung added a commit that referenced this issue Dec 13, 2017
@hwanseung
Remove unused file. (#217)
2760d51 
it was unused file.
but it was included when dictionary feature work.

ISSUE=#169
@hwanseung hwanseung mentioned this issue Dec 13, 2017
Merged
romandev pushed a commit that referenced this issue Dec 15, 2017
@hwanseung @romandev
Converting native object from javascript dictionary type (#219)
9d49a40 
When javascript dictionary type passed as parameter,
it should be pass as native object at cpp side.
so it is need to convert to native object.
present, this CL has test which take double type.
so we should add other tests for other primitive types.

ISSUE=#169
@hwanseung hwanseung mentioned this issue Dec 30, 2017
Merged
romandev pushed a commit that referenced this issue Jan 3, 2018
@hwanseung @romandev
Add test for string member of dictionaries (#225)
cca347a 
When dictionary has string member, "std::" was missed in front of string
keyword. So, it makes build error.

ISSUE=#169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwanseung hwanseung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hwanseung